Closed
Bug 1483003
Opened 7 years ago
Closed 7 years ago
Mochitests with some failures and some passes have exit code as if no failures
Categories
(Testing :: Mochitest, enhancement)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1473392
People
(Reporter: Mardak, Unassigned)
References
Details
In bug 1482246, we noticed that chaining `./mach test …mochitests && ./mach test …more…mochitests` did not fail on mochitest failure.
I believe the issue comes from the code added in bug 1209463.
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/testing/mochitest/runtests.py#2646
if not result and not self.countpass:
# either tests failed or no tests run
result = 1
`and not self.countpass` makes it so if there's any passes, the result is unchanged -> 0
Perhaps it should be `and self.countfail` instead?
Flags: needinfo?(ahal)
Reporter | ||
Comment 1•7 years ago
|
||
Oh, I suppose if there's no passes either, it should fail? ;)
Comment 2•7 years ago
|
||
I think that line is working as intended. It's basically saying "if we didn't detect any failures, but we also didn't detect anything passing, something must have gone wrong so return a failure".
Flags: needinfo?(ahal)
Reporter | ||
Comment 3•7 years ago
|
||
Looks like the condition is being changed in bug 1473392.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•